Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High/Low Water mark support? #31

Open
junkblocker opened this issue Jul 14, 2018 · 2 comments
Open

High/Low Water mark support? #31

junkblocker opened this issue Jul 14, 2018 · 2 comments

Comments

@junkblocker
Copy link

I want to be able to PUSH only a limited number of packets to avoid losing them if the PULL side crashes. Is this possible or planned? Looking at the code I see that go's io.ReadWriteCloser is used underneath so it seems no message level limiting is possible.

@sbinet
Copy link
Contributor

sbinet commented Jul 15, 2018

It probably isn't possible right now but it's definitely something most people will need at some point.

I don't think having based the transport on 'io.ReadWriteCloser' will prevent to implement that (but happy to hear otherwise)

@junkblocker
Copy link
Author

Since I need it soon, I'd like to take a stab at implementing this. Any general clues about the implementation design to save me time investigating would be highly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants