Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less obtrusive way to ask users to collect telemetry #3672

Open
isidorn opened this issue Jul 25, 2024 · 5 comments
Open

Less obtrusive way to ask users to collect telemetry #3672

isidorn opened this issue Jul 25, 2024 · 5 comments
Labels
bug Something isn't working VSCode

Comments

@isidorn
Copy link

isidorn commented Jul 25, 2024

Hi VS Code PM Here 👋

  1. Install CodeQl
  2. See telemetry dialog 🐛

Here are our telemetry collection guidelines https://code.visualstudio.com/api/extension-guides/telemetry

Based on that I strongly suggest that you do not show this dialog, but instead just respect the respect the isTelemetryEnabled and onDidChangeTelemetryEnabled from the vscode API. That will make a much smoother user experience, and the user just has to disable telemetry once in vscode and all the extensions will respect that. Thanks

Image

fyi @TylerLeonhardt

@isidorn isidorn added the bug Something isn't working label Jul 25, 2024
@jf205
Copy link
Contributor

jf205 commented Aug 5, 2024

Hi @isidorn

Thanks for creating this issue and for the recommendation. I'll discuss this change with the team.

@jf205
Copy link
Contributor

jf205 commented Aug 5, 2024

Discussed with the team: we agree that we should respect the isTelemetryEnabled and onDidChangeTelemetryEnabled from the vscode API. Currently unsure what size effort this would be and therefore also unsure when we'll be able to pick it up.

@isidorn
Copy link
Author

isidorn commented Aug 5, 2024

Thanks for discussing. I do not think this should be a large investment.

@stonish
Copy link

stonish commented Aug 8, 2024

@isidorn We discussed this a little further as a team, we're onboard with making this change but it's not something that we think we can tackle right now. Even though the investment shouldn't be too large, we're working towards some tight deadlines for shipping new features at Universe and can't take on anything else unless absolutely necessary.

I'm going to set this up for us to revisit it after Universe when I expect we'll have more capacity to take this on. If you think this is a mistake, please let me know and/or re-add this issue to our team board to be re-triaged

@isidorn
Copy link
Author

isidorn commented Aug 8, 2024

Post Universe makes sense. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VSCode
Projects
None yet
Development

No branches or pull requests

3 participants