Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension erroneously suggests certain QL keywords in QLDoc #1564

Open
Marcono1234 opened this issue Oct 3, 2022 · 1 comment
Open

Extension erroneously suggests certain QL keywords in QLDoc #1564

Marcono1234 opened this issue Oct 3, 2022 · 1 comment
Labels
bug Something isn't working VSCode

Comments

@Marcono1234
Copy link
Contributor

Describe the bug
Possibly related to #391 and #556

The extension erroneously suggests certain QL keywords while writing QLDoc, these keywords seem to be affected: class, extends, from, import, select, where

Also a bit annoying is that these suggestsions pop up automatically when you write a period (.), and when you then press Enter to continue in the next line, you actually select that suggested keyword instead.

Screenshot showing the suggestsions pop-up

Version
Extension:

CodeQL extension version: 1.7.0 
CodeQL CLI version: 2.11.0 
Platform: win32 x64

VS Code:

Version: 1.71.2 (user setup)
Commit: 74b1f979648cc44d385a2286793c226e611f59e7
Date: 2022-09-14T21:03:37.738Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.19043
Sandboxed: No

To reproduce

  1. Open the Quick Query
  2. Write any small query
  3. Write a QLDoc for the file, e.g.
    /**
     * test<HERE>
     */
    
  4. At the position marked with <HERE> write a period (.)
    ❌ Bug: The extension suggests QL keywords

Expected behavior
No QL keywords should be suggested in QLDoc.

@Marcono1234 Marcono1234 added the bug Something isn't working label Oct 3, 2022
@github-actions github-actions bot added the VSCode label Oct 3, 2022
@aeisenberg
Copy link
Contributor

Thanks for reporting. This seems to be an issue with our textmate grammar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VSCode
Projects
None yet
Development

No branches or pull requests

2 participants