Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide server-related APIs behind a feature gate #164

Open
Xuanwo opened this issue Feb 17, 2025 · 2 comments
Open

Hide server-related APIs behind a feature gate #164

Xuanwo opened this issue Feb 17, 2025 · 2 comments

Comments

@Xuanwo
Copy link

Xuanwo commented Feb 17, 2025

Hi, I'm working on addressing apache/opendal#5620.

This crate is critical for me, but I only care about the client side and don't want all my users to depend on axum. Would it be possible to hide server-related APIs behind a feature gate instead?

@tclem
Copy link
Member

tclem commented Feb 18, 2025

This is a good idea, thanks for opening an issue @Xuanwo. Would you like to take a crack at it and submit a pull request? Otherwise, I can't promise when we'll get around to this as it's low priority for our current project since we always end up with both clients and servers in the same app anyway.

@Xuanwo
Copy link
Author

Xuanwo commented Feb 18, 2025

Thank you for the response! I finally implemented the feature by hand since twirp is really simple. I love it 😝

Back to this issue, I will take a look over this when I have time. But I have to declare that it's also not on the top of my task list 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants