You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All of the fields here are optional. Is that correct? I suspect not.
For example: deployment_callback_url: what is the meaning of a deployment protection rule webhook event that doesn't include a callback URL, and what would one even do with such a thing? Same thing for deployment — how does a deployment protection rule fire on a null or missing deployment…?
(intallation, similarly.)
I've not seen either of those in the wild, either, which further makes me suspect they're actually always present. It'd be nice if the schema had that. (And then, I could just do a rote translation to T, instead of Optional<T> for those fields.)
Expected
Probably, some or all of these fields are required. It'd be great if the docs specified.
The text was updated successfully, but these errors were encountered:
Schema Inaccuracy
The schema for a deployment protection rule webhook event is:
(In the docs: https://docs.github.com/en/webhooks/webhook-events-and-payloads#deployment_protection_rule)
All of the fields here are optional. Is that correct? I suspect not.
For example:
deployment_callback_url
: what is the meaning of a deployment protection rule webhook event that doesn't include a callback URL, and what would one even do with such a thing? Same thing fordeployment
— how does a deployment protection rule fire on anull
or missing deployment…?(
intallation
, similarly.)I've not seen either of those in the wild, either, which further makes me suspect they're actually always present. It'd be nice if the schema had that. (And then, I could just do a rote translation to
T
, instead ofOptional<T>
for those fields.)Expected
Probably, some or all of these fields are required. It'd be great if the docs specified.
The text was updated successfully, but these errors were encountered: