You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm working on an addition to insights-web (PR) that requires an upgrade to Chart.js 4. Chart.js 4 added typescript .d.ts definitions for various exported types. This breaks the GitHub eslint rules because the linter isn't able to resolve the imported types, despite everything compiling correctly. I was able to fix the linting by adding and configuring eslint-import-resolver-typescript to the project. I wanted to submit this issue here though because this seems like a better addition to estlint-plugin-github, that way we have org-wide TS linting support. There's also an alternative eslint-plugin-i package that claims to be faster than eslint-plugin-import.
The text was updated successfully, but these errors were encountered:
Imho, typescript should be optional in a separate package, e.g. eslint-plugin-github-typescript, so that people who use it for JS don't pull in a huge load of typescript-related dependencies.
I'm working on an addition to insights-web (PR) that requires an upgrade to Chart.js 4. Chart.js 4 added typescript
.d.ts
definitions for various exported types. This breaks the GitHub eslint rules because the linter isn't able to resolve the imported types, despite everything compiling correctly. I was able to fix the linting by adding and configuring eslint-import-resolver-typescript to the project. I wanted to submit this issue here though because this seems like a better addition toestlint-plugin-github
, that way we have org-wide TS linting support. There's also an alternative eslint-plugin-i package that claims to be faster thaneslint-plugin-import
.The text was updated successfully, but these errors were encountered: