Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force es5 trailing commas #324

Open
maraisr opened this issue Oct 11, 2022 · 3 comments
Open

Force es5 trailing commas #324

maraisr opened this issue Oct 11, 2022 · 3 comments

Comments

@maraisr
Copy link
Member

maraisr commented Oct 11, 2022

We should configure prettier to es5 trailing commas. Why? makes diffs and reordering so much easier.
@dgreif
Copy link
Contributor

dgreif commented Jun 2, 2023

We've implemented this in github/github and are happy with the results. @maraisr do you think this would be worthy of a breaking change for this package if we made the change here?

@maraisr
Copy link
Member Author

maraisr commented Jun 2, 2023

Hi @dgreif thank you for that. I also noticed we turned this setting to all within the prettier config. And yeah been super happy with the results. I think this is worthy of a breaking change yes.

@dgreif
Copy link
Contributor

dgreif commented Jun 2, 2023

Thanks for pointing out the prettier change! Would you mind opening a PR for this? I'm happy to approve, as long as no one else on my team objects, and we can cut a breaking release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maraisr @dgreif