Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve example workflow #36383

Closed
1 task done
rufer7 opened this issue Feb 19, 2025 · 5 comments · Fixed by #36384
Closed
1 task done

Fix and improve example workflow #36383

rufer7 opened this issue Feb 19, 2025 · 5 comments · Fixed by #36384
Labels
content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert triage Do not begin working on this issue until triaged by the team

Comments

@rufer7
Copy link
Contributor

rufer7 commented Feb 19, 2025

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/enterprise-cloud@latest/copilot/rolling-out-github-copilot-at-scale/reminding-inactive-users

What part(s) of the article would you like to see updated?

This week I discovered this great new article about Reminding inactive users to use their GitHub Copilot license. Thanks a lot for providing this!

While trying to get the example workflow up and running, I noticed a few things that could be improved.

  • Missing support for running the workflow manually (i.e. for testing purposes)
  • Least privilege for GITHUB_TOKEN
  • $ORGANIZATION_VAR is not defined (gh: Not Found (HTTP 404) -> $ORGANIZATION_VAR) - to be replaced with ${{ github.repository_owner }}
  • Workflow fails if a user with a GitHub copilot license has last_activity_at set to null (date: invalid date ‘null’)
  • GITHUB_TOKEN: ${{ github.token }} did not work

I'll create a pull request asap with the fixes and improvements.

Additional information

See https://blog.rufer.be/2025/02/20/howto-identify-and-remind-inactive-github-copilot-users/

@rufer7 rufer7 added the content This issue or pull request belongs to the Docs Content team label Feb 19, 2025
Copy link

welcome bot commented Feb 19, 2025

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 19, 2025
@felicitymay
Copy link
Contributor

Hi @rufer7 👋🏻

Many thanks for taking the time to open this issue and the accompanying pull request ✨

I particularly appreciate the very clear description of what you want to update. It's also great to know that you found the article useful.

I'm going to triage this for an SME review because we'll want to test your changes.

@felicitymay felicitymay added the needs SME This proposal needs review from a subject matter expert label Feb 20, 2025
Copy link
Contributor

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

@rufer7
Copy link
Contributor Author

rufer7 commented Feb 20, 2025

Hi @rufer7 👋🏻

Many thanks for taking the time to open this issue and the accompanying pull request ✨

I particularly appreciate the very clear description of what you want to update. It's also great to know that you found the article useful.

I'm going to triage this for an SME review because we'll want to test your changes.

@felicitymay you're welcome. Happy to contribute. I also blogged about it: https://blog.rufer.be/2025/02/20/howto-identify-and-remind-inactive-github-copilot-users/

@sunbrye
Copy link
Contributor

sunbrye commented Feb 21, 2025

@rufer7 Thank you for making a contribution and working through any bugs you found on the workflow ✨ The updates look great, especially the support for null last_activity_at. I've approved your PR and gone ahead and merged it in ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants