Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible race condition in hhnet.sh script #370

Open
pau-hedgehog opened this issue Feb 5, 2025 · 0 comments
Open

Possible race condition in hhnet.sh script #370

pau-hedgehog opened this issue Feb 5, 2025 · 0 comments
Assignees
@pau-hedgehog

Comments

@pau-hedgehog
Copy link
Contributor

I hit what seems #292 in env-3.

22:58:26 ERR setup-vpcs: configuring servers: configuring server "server-2": running hhnet "bond 1002 enp2s1 enp2s2": Process exited with status 1: out: Failed to get IP address for bond0.1002

According to @Frostman

it's MCLAG-connected server, ports on both switches are up but portchannel is lacp-fail and server-1 (exactly same mclag) is okay

as7326-01# show mclag brief 
 
Domain ID            : 100
Role                 : active
Session Status       : up
Peer Link Status     : up
Source Address       : 172.30.95.0
Peer Address         : 172.30.95.1
Session Vrf          : default
Peer Link            : PortChannel250
Keepalive Interval   : 1 secs
Session Timeout      : 30 secs
Delay Restore        : 300 secs
System Mac           : 68:21:5f:a6:60:75
Mclag System Mac     : 
 
 
Number of MLAG Interfaces:2
-----------------------------------------------------------
MLAG Interface       Local/Remote Status 
-----------------------------------------------------------
PortChannel2             up/up
PortChannel3             down/down

so, just running hhnet cleanup and hhnet bond 1002 enp2s1 enp2s2 helped - it's working fine now
that particular issue looks like maybe some race or bug when we're creating a bond using netlink

So I'm raising this to make hhnet.sh script %100 failproof (hopefully)
@pau-hedgehog pau-hedgehog self-assigned this Feb 5, 2025
pau-hedgehog added a commit that referenced this issue Feb 5, 2025
@pau-hedgehog
Failproof hhnet script
938bd3a 
Fixes #370

Signed-off-by: Pau Capdevila <[email protected]>
@pau-hedgehog pau-hedgehog mentioned this issue Feb 5, 2025
Closed
pau-hedgehog added a commit that referenced this issue Feb 5, 2025
@pau-hedgehog
Failproof hhnet script
2526ed9 
Fixes #370

Signed-off-by: Pau Capdevila <[email protected]>
pau-hedgehog added a commit that referenced this issue Feb 6, 2025
@pau-hedgehog
Failproof hhnet script
dd5b829 
Fixes #370

Signed-off-by: Pau Capdevila <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pau-hedgehog pau-hedgehog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Failproof hhnet script githedgehog/fabricator
1 participant
@pau-hedgehog