Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InnoSetup from 6.1.0 to 6.4.0 #587

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dennisameling
Copy link
Contributor

These changes are the output of running ./update-inno-setup.sh locally.

Release notes: https://jrsoftware.org/files/is6-whatsnew.htm

Tested a git-artifacts pipeline with the updated installer version, and everything seems to be working fine.

@dennisameling dennisameling requested a review from dscho January 10, 2025 17:04
@rimrul rimrul linked an issue Jan 10, 2025 that may be closed by this pull request
@rimrul
Copy link
Member

rimrul commented Jan 10, 2025

#568 updated to 6.3.3, but apparently /open pr didn't pick up the .isl files.

@dscho
Copy link
Member

dscho commented Jan 10, 2025

#568 updated to 6.3.3, but apparently /open pr didn't pick up the .isl files.

Maybe we should fix that? I do not really understand what is broken, though, because https://github.com/git-for-windows/git-for-windows-automation/blob/c47fca11b13202133c63df453efcafdb9511e1fd/update-scripts/version/innosetup#L11 looks fine to me...

@dscho
Copy link
Member

dscho commented Jan 10, 2025

Also: I would like to hold off upgrading from InnoSetup v6.3.3 to v6.4.0 for a bit, for these reasons:

  • As I mentioned here, the new version offers an opportunity to drop the finicky ExecWithCapture() function. This will need some work, and especially thorough testing.
  • I released Git for Windows v2.48.0-rc2 yesterday. It already was delayed a lot by many issues I faced, from a gettext update requiring a new library I had not included in the minimal-sdk artifact to build problems caused by big changes integrated very, very late in Git's release cycle, to outright test failures, to new flaky behavior. And this is all without any meaningful testing because Git's release cycle did not care that it was the winter holidays and sane people did not touch their computers. I would really like to keep a chance alive that the upcoming Git for Windows isn't completely broken, and to bring that about I am now extremely reluctant to integrate even more new stuff in addition to the gifts imparted by the Git project.
  • As a rule, I like to integrate bigger changes a week or two after releases, to give those changes maximal exposure before being part of an official Git for Windows release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New innosetup version] is-6_4_0
3 participants