Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebView2Loader assembly has a bad signature #462

Closed
mjcheetham opened this issue Sep 22, 2021 · 3 comments
Closed

WebView2Loader assembly has a bad signature #462

mjcheetham opened this issue Sep 22, 2021 · 3 comments
Labels
bug A bug in Git Credential Manager platform:windows Specific to the Windows platform

Comments

@mjcheetham
Copy link
Collaborator

We've had several complaints that the WebView2Loader.dll binary that ships inside of GCM causes signing problems. First for getting Git for Windows submitted to the Microsoft Store (git-for-windows/git#1146 (comment)), and more recently problems with GitHub Desktop.

The WebView2Loader.dll comes in from our dependency on MSAL.NET's Microsoft.Identity.Client.Desktop package. We need that package on Windows to bring in support for WAM when targeting .NET Framework (as apposed to netX-windows*).

The annoying thing is that we don't even use WebView2 because of various problems with it. We tried to move to .NET 5 on Window in the past and this resulted in an unacceptable bloat in binary size. When we turned all the optimisations/linking up to the highest level we only managed to reduce binary size a small amount, but broke things like UI.

We may have to drop WAM entirely. cc: @bgavrilMS
@mjcheetham mjcheetham added bug A bug in Git Credential Manager platform:windows Specific to the Windows platform labels Sep 22, 2021
sergiou87 added a commit to desktop/desktop that referenced this issue Sep 22, 2021
@sergiou87
Delete WebView2Loader.dll from Windows builds
0505ea2 
That filed cannot be signed and makes our builds fail. More info: git-ecosystem/git-credential-manager#462
sergiou87 added a commit to desktop/desktop that referenced this issue Sep 22, 2021
@sergiou87
Delete WebView2Loader.dll from Windows builds
0d86e5b 
That file cannot be signed and makes our builds fail. More info: git-ecosystem/git-credential-manager#462
@bgavrilMS
Copy link

bgavrilMS commented Sep 22, 2021 via email

@mjcheetham
Copy link
Collaborator Author

We can split webview2 out of msal and msal.desktop

Yeah, I think this would be required if we're to keep Windows Broker/WAM support.

I tried again to move GCM to .NET 6 (net6-windowsXXX) on Windows and failed. There are too many issues today, mainly around size/trimming, and I've found out today that ".NET Single File" executables are not supported on Windows 7!!

https://docs.microsoft.com/en-us/dotnet/core/deploying/single-file#:~:text=Single%20file%20deployment%20isn%27t%20compatible%20with%20Windows%207.

@mjcheetham
Copy link
Collaborator Author

It looks like this is less a problem with the WebView2Loader binary, nor the GCM distributed copy, but the Git for Windows package!

git-for-windows/git#3332 (comment)

Looks like Git for Windows' build was stripping off the PE signature and causing an invalid signature. This has been fixed in git-for-windows/build-extra#368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug in Git Credential Manager platform:windows Specific to the Windows platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjcheetham @bgavrilMS