Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review offline support #3739

Open
bruno-garcia opened this issue Nov 8, 2024 · 0 comments
Open

Review offline support #3739

bruno-garcia opened this issue Nov 8, 2024 · 0 comments

Comments

@bruno-garcia
Copy link
Member

A customer who has a MAUI app that goes offline for extended amount of time has reported that events are getting lost.
No client reports indicate data being dropped.

I expected at least:

_options.ClientReportRecorder.RecordDiscardedEvents(DiscardReason.CacheOverflow, envelope);

Reading the code it seems like we don't delete files if the failure reason is network connectivity:

catch (Exception ex) when (IsNetworkError(ex))
{
if (_options.NetworkStatusListener is PollingNetworkStatusListener pollingListener)
{
pollingListener.Online = false;
}
_options.LogError(ex, "Failed to send cached envelope: {0}, retrying after a delay.", file);
// Let the worker catch, log, wait a bit and retry.
throw;

But I believe we should run some tests:

  1. Put the simulator offline. Generate some events. Let the buffer fill (30 by default), do we get the client reports?
  2. If the failure is a timeout, do we delete the issue (aka: review the heuristics for "Network Error")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant