Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic Heap dump collection #2580

Open
bruno-garcia opened this issue Aug 25, 2023 · 4 comments · May be fixed by #3667
Open

Automatic Heap dump collection #2580

bruno-garcia opened this issue Aug 25, 2023 · 4 comments · May be fixed by #3667
Assignees
@jamescrosswell
Labels
Feature New feature or request
Milestone
5.0.0

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Aug 25, 2023 •
edited
Loading

Specify a memory threshold or other trigger (and API) to automatically capture a heap dump

Sentry attachment preview can be extended to load: https://github.com/1hub/dotnet-heapview/
https://1hub.github.io/dotnet-heapview/
@bitsandfoxes bitsandfoxes added the Feature New feature or request label Mar 4, 2024
@jamescrosswell
Copy link
Collaborator

I think that's what this POC is related to right?

@bitsandfoxes
Copy link
Contributor

Do you have an idea how much work it's going to be to turn the POC into some MVP?

@jamescrosswell
Copy link
Collaborator

Do you have an idea how much work it's going to be to turn the POC into some MVP?

A day or two to get what's there productionised.

A little bit more to figure out how to bundle gcdump in our nuget and run it from there.

And a little bit more to do something intelligent with the resulting dump (e.g. send it as an attachment in an issue to Sentry).

About 3 days all up.

@bitsandfoxes bitsandfoxes added this to the 5.0.0 milestone Sep 26, 2024
@jamescrosswell jamescrosswell linked a pull request Oct 9, 2024 that will close this issue
Open
@jamescrosswell jamescrosswell self-assigned this Oct 10, 2024
@jamescrosswell jamescrosswell linked a pull request Oct 10, 2024 that will close this issue
Automatically capture heap dumps #3667
Open
@bruno-garcia
Copy link
Member Author

I've fork Filip's repo: https://github.com/getsentry/dotnet-heapview
Lets see if we get this reviewed by folks, and we can load the dumps in the attachment preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamescrosswell jamescrosswell

Labels
Feature New feature or request
Projects
GDX
Status: No status
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Automatically capture heap dumps getsentry/sentry-dotnet
3 participants
@jamescrosswell @bruno-garcia @bitsandfoxes