Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior of slim_frame_data #4057

Open
loewenheim opened this issue Sep 20, 2024 · 0 comments
Open

Unexpected behavior of slim_frame_data #4057

loewenheim opened this issue Sep 20, 2024 · 0 comments
Labels
bug Something isn't working filler Requires little effort to resolve. Ready to be picked up anytime.

Comments

@loewenheim
Copy link
Contributor

The function slim_frame_data is supposed to clear pre- and post-context of interior frames beyond a certain threshold. We have seen a case where it instead removes the pre- and post-context of the top frame, which is also the only in-app frame and the only one that even has pre- and post-context. Adding another in-app frame immediately below the top one will instead result in that new frame's data being removed and that in the top frame being preserved.

This behavior is extremely surprising and the logic in the function itself is unclear. We need to figure out what exactly the intended behavior of slim_frame_data is and implement it correctly.

Event payload exhibiting this problem: ruby-payload-edited.json

@olksdr olksdr added bug Something isn't working filler Requires little effort to resolve. Ready to be picked up anytime. labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working filler Requires little effort to resolve. Ready to be picked up anytime.
Projects
None yet
Development

No branches or pull requests

2 participants