This repository has been archived by the owner on Apr 9, 2021. It is now read-only.
fix: list only smart phones for scanning bluetooth devices #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lakshyagupta21 can you please review my PR's if you are free |
huangyz0918
reviewed
Feb 3, 2020
skunkworks_crow/src/main/java/org/odk/share/views/ui/bluetooth/BluetoothListAdapter.java
Show resolved
Hide resolved
ajay-prabhakar
force-pushed
the
btDevice
branch
from
4e3a15d
to
f223b1c
Compare
@huangyz0918 My friend checked and he said it is showing as expected @lakshyagupta21 I added the check for NPE, can you please review now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #346
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
With the help of
BluetoothClasschecked if the device is the smartphone then added into Bluetooth device list with help of if the conditionHow does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
By adding this fix user can directly select the device to transfer forms
GIF
list of devices before this feature
list of devices after this feature
Before submitting this PR, please make sure you have:
./gradlew checkCodeand confirmed all checks still pass OR confirm CircleCI build passes