-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checkpointing/restarting with HDF5 #35
Comments
As of right now, the built-in |
To instantiate a simulation, the module in Many of the arguments are keyword arguments that are readily handled by a Some arguments are more complicated. Every module in Therefore, in order for Sapphire to have the ability to instantiate a simulation from a JSON, certain requirements must be met, and much generality must be hidden. Specifying a simulation with a JSON is straightforward for any of the modules in |
The water freezing benchmark will make a nice test for the JSON specification and checkpoint/restart functionality. Rather than the somewhat complicated implementation currently in |
The JSON idea was attached to this issue a while back and it still might be nice to provide a simplified interface accepting JSON input for fully specified simulation classes; but right now it's not clear that this will be very useful. What's really needed is the checkpointing/restarting with HDF5. |
Firedrake should handle what we need right now: https://www.firedrakeproject.org/checkpointing.html At a minimum, |
Right now, solutions are only written to VTK files. For post-processing, this is only accurate for CG1 bases. For restarting simulations, this is mostly useless.
sapphire.Simulation
should have a simplified interface tofiredrake.DumbCheckpoint
for checkpointing and restarting.The text was updated successfully, but these errors were encountered: