nova: review assertions in core/base of base-nova #5443
Assignees
Labels
Comments
alex-ab
added a commit
to alex-ab/genode
that referenced
this issue
Feb 5, 2025
The commit will improve diagnostics, if a core thread dies (which should never happen) with an hardware exception beside a page fault, e.g. general protection fault or undefined opcode. Without the commit we may not see this circumstance easily. Issue genodelabs#5443
alex-ab
added a commit
to alex-ab/genode
that referenced
this issue
Feb 5, 2025
alex-ab
added a commit
to alex-ab/genode
that referenced
this issue
Feb 5, 2025
alex-ab
added a commit
to alex-ab/genode
that referenced
this issue
Feb 5, 2025
alex-ab
added a commit
to alex-ab/genode
that referenced
this issue
Feb 5, 2025
alex-ab
added a commit
to alex-ab/genode
that referenced
this issue
Feb 5, 2025
alex-ab
added a commit
to alex-ab/genode
that referenced
this issue
Feb 5, 2025
|
I created several commits and finally removed nova_die as utility completely. We may squash all the "remove nova_die ..." commits, I just kept them for review reasons. |
alex-ab
added a commit
to alex-ab/genode
that referenced
this issue
Feb 5, 2025
alex-ab
added a commit
to alex-ab/genode
that referenced
this issue
Feb 5, 2025
alex-ab
added a commit
to alex-ab/genode
that referenced
this issue
Feb 5, 2025
alex-ab
added a commit
to alex-ab/genode
that referenced
this issue
Feb 5, 2025
nfeske
pushed a commit
that referenced
this issue
Feb 5, 2025
The commit will improve diagnostics, if a core thread dies (which should never happen) with an hardware exception beside a page fault, e.g. general protection fault or undefined opcode. Without the commit we may not see this circumstance easily. Issue #5443
nfeske
pushed a commit
that referenced
this issue
Feb 5, 2025
nfeske
pushed a commit
that referenced
this issue
Feb 5, 2025
nfeske
pushed a commit
that referenced
this issue
Feb 5, 2025
nfeske
pushed a commit
that referenced
this issue
Feb 5, 2025
nfeske
pushed a commit
that referenced
this issue
Feb 5, 2025
nfeske
pushed a commit
that referenced
this issue
Feb 5, 2025
|
Excellent! The changes are very nice to see. I merged your commit series to staging and will do the squashing later when mastering. |
alex-ab
added a commit
to alex-ab/genode
that referenced
this issue
Feb 6, 2025
chelmuth
pushed a commit
that referenced
this issue
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In base-nova there are several assertions which should be turned into proper error codes or can be removed if they check for esoteric cases as in #5399. During #5307 such a assertion stopped the booting of Sculpt very early, but actually it was not too fatal as it seemed. Since we now get in a phase, where we will have more machines without easy debugging support, we should be careful about using developer assertions.
The text was updated successfully, but these errors were encountered: