Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome fixed routing bug #233

Open
tinco opened this issue May 27, 2014 · 4 comments · May be fixed by #279
Open

Chrome fixed routing bug #233

tinco opened this issue May 27, 2014 · 4 comments · May be fixed by #279
Labels
client-side

Comments

@tinco
Copy link

tinco commented May 27, 2014

Hi,

The bug you workaround on this line: https://github.com/flatiron/director/blob/master/lib/director/browser.js#L76

Has been fixed and has landed in the latest Chrome version. So supposedly it is safe to immediately install the handler now.

https://code.google.com/p/chromium/issues/detail?id=63040
@beaugunderson
Copy link
Contributor

Awesome, I think supporting the last three versions of Chrome is probably a good idea, meaning that when Chrome hits 36.x we can remove the workaround (it looks like the bug was fixed in Chrome 33 or 34).

@cmwelsh
Copy link

cmwelsh commented Dec 18, 2014

Please go ahead and remove this fix. It actually causes an error when a user clicks a link within 500 milliseconds and window.onpopstate is still undefined.

@cmwelsh
Copy link

cmwelsh commented Dec 18, 2014

For people searching this error on Google, it manifests as object is not a function...

@cmwelsh cmwelsh linked a pull request Jan 20, 2015 that will close this issue
Open
@kuon
Copy link

kuon commented Feb 11, 2015

It is causing an issue for me as well, as I may redirect the user on page load under certain conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client-side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error when user clicks a link within 500ms cmwelsh/director
4 participants
@tinco @beaugunderson @cmwelsh @kuon