Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle FiefRequestError gracefully in current_user integrations #12

Open
frankie567 opened this issue Sep 7, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@frankie567
Copy link
Member

Currently, in the current_user functions from FastAPI/Flask/CLI integrations, we assume the token is valid and thus that the request to Fief will succeed.

However, there might be cases where the client considers the token as valid, but the Fief server does not. Typically, if we change our token structure and the client is outdated, the client will accept it but the server will reject.

We should handle this case more gracefully by raising a proper Unauthorized error when this happens.

@frankie567 frankie567 added the bug Something isn't working label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant