From 769911f119b1d7860fd52b2098982509f02e932c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Harper?= Date: Sat, 27 Apr 2024 10:53:28 -0400 Subject: [PATCH 1/3] fix GitHub Workflow to check syntax with Vale Not using latest version, and pin to a specific version. --- .github/workflows/check-syntax.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/check-syntax.yml b/.github/workflows/check-syntax.yml index d89a2b9..48d7edb 100644 --- a/.github/workflows/check-syntax.yml +++ b/.github/workflows/check-syntax.yml @@ -29,15 +29,9 @@ jobs: - name: Download base Vocab accept.txt run: wget https://raw.githubusercontent.com/fharper/gh-configs/main/styles/Vocab/base/accept.txt -O styles/Vocab/base/accept.txt - - name: Get latest version of Vale - id: lastversion - uses: dvershinin/lastversion-action@v0.0.3 - with: - repository: errata-ai/vale - - name: Install Vale run: | - wget https://github.com/errata-ai/vale/releases/download/v${{ steps.lastversion.outputs.last_version }}/vale_${{ steps.lastversion.outputs.last_version }}_Linux_64-bit.tar.gz -O vale.tar.gz + wget https://github.com/errata-ai/vale/releases/download/v2.30.0/vale_2.30.0_Linux_64-bit.tar.gz -O vale.tar.gz tar -xvzf vale.tar.gz vale rm vale.tar.gz From 602fde575f31a8ddabbbd4c3f45973b26c8bd857 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Harper?= Date: Sat, 27 Apr 2024 11:27:21 -0400 Subject: [PATCH 2/3] Pin eslint version instead of using latest I will move to the flat eslint configuration file when I have time. I did the same with actions/checkout + eslint-formatter-pretty. I upgraded Node.js to 20.12.2. Lastly, I updated the GitHub action versions of actions/setup-node + suisei-cn/actions-download-file to the latest. --- .github/workflows/check-nodejs.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/check-nodejs.yml b/.github/workflows/check-nodejs.yml index 1aa1e2a..cca0437 100644 --- a/.github/workflows/check-nodejs.yml +++ b/.github/workflows/check-nodejs.yml @@ -8,25 +8,25 @@ jobs: steps: - name: Checkout this repository - uses: actions/checkout@master + uses: actions/checkout@v4.1.1 - name: Setup Node.js - uses: actions/setup-node@v3.7.0 + uses: actions/setup-node@v4.0.2 with: - node-version: v19.6.0 + node-version: v20.12.2 cache: npm - name: Install ESLint - run: npm install -g eslint + run: npm install -g eslint@8.56.0 - name: Install ESLint configurations dependencies - run: npm install eslint-config-standard eslint-plugin-import eslint-plugin-n eslint-plugin-promise eslint-formatter-pretty + run: npm install eslint-config-standard eslint-plugin-import eslint-plugin-n eslint-plugin-promise eslint-formatter-pretty@v5.0.0 - name: Download .eslintrc.yml - uses: suisei-cn/actions-download-file@v1.4.0 + uses: suisei-cn/actions-download-file@v1.6.0 with: url: "https://raw.githubusercontent.com/fharper/gh-configs/main/.eslintrc.yml" # Rules https://eslint.org/docs/latest/rules/ - name: Run ESLint - run: eslint . --format=pretty --ext .js + run: eslint . --format=pretty --config .eslintrc.yml --ext .js From d5888e1d673ccb1551a7538360d4d3f8836005cd Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat, 27 Apr 2024 11:31:53 -0400 Subject: [PATCH 3/3] Bump express from 4.18.2 to 4.19.2 (#11) --- package-lock.json | 42 ++++++++++++++---------------------------- package.json | 2 +- 2 files changed, 15 insertions(+), 29 deletions(-) diff --git a/package-lock.json b/package-lock.json index 2b373c9..0cfd3af 100644 --- a/package-lock.json +++ b/package-lock.json @@ -12,7 +12,7 @@ "@slack/bolt": "^3.8.1", "@slack/events-api": "^3.0.1", "dotenv": "^8.6.0", - "express": "^4.17.2" + "express": "^4.19.2" } }, "node_modules/@slack/bolt": { @@ -462,12 +462,12 @@ } }, "node_modules/body-parser": { - "version": "1.20.1", - "resolved": "https://registry.npmjs.org/body-parser/-/body-parser-1.20.1.tgz", - "integrity": "sha512-jWi7abTbYwajOytWCQc37VulmWiRae5RyTpaCyDcS5/lMdtwSz5lOpDE67srw/HYe35f1z3fDQw+3txg7gNtWw==", + "version": "1.20.2", + "resolved": "https://registry.npmjs.org/body-parser/-/body-parser-1.20.2.tgz", + "integrity": "sha512-ml9pReCu3M61kGlqoTm2umSXTlRTuGTx0bfYj+uIUKKYycG5NtSbeetV3faSU6R7ajOPw0g/J1PvK4qNy7s5bA==", "dependencies": { "bytes": "3.1.2", - "content-type": "~1.0.4", + "content-type": "~1.0.5", "debug": "2.6.9", "depd": "2.0.0", "destroy": "1.2.0", @@ -475,7 +475,7 @@ "iconv-lite": "0.4.24", "on-finished": "2.4.1", "qs": "6.11.0", - "raw-body": "2.5.1", + "raw-body": "2.5.2", "type-is": "~1.6.18", "unpipe": "1.0.0" }, @@ -484,20 +484,6 @@ "npm": "1.2.8000 || >= 1.4.16" } }, - "node_modules/body-parser/node_modules/raw-body": { - "version": "2.5.1", - "resolved": "https://registry.npmjs.org/raw-body/-/raw-body-2.5.1.tgz", - "integrity": "sha512-qqJBtEyVgS0ZmPGdCFPWJ3FreoqvG4MVQln/kCgF7Olq95IbOp0/BWyMwbdtn4VTvkM8Y7khCQ2Xgk/tcrCXig==", - "dependencies": { - "bytes": "3.1.2", - "http-errors": "2.0.0", - "iconv-lite": "0.4.24", - "unpipe": "1.0.0" - }, - "engines": { - "node": ">= 0.8" - } - }, "node_modules/buffer-equal-constant-time": { "version": "1.0.1", "resolved": "https://registry.npmjs.org/buffer-equal-constant-time/-/buffer-equal-constant-time-1.0.1.tgz", @@ -588,9 +574,9 @@ } }, "node_modules/cookie": { - "version": "0.5.0", - "resolved": "https://registry.npmjs.org/cookie/-/cookie-0.5.0.tgz", - "integrity": "sha512-YZ3GUyn/o8gfKJlnlX7g7xq4gyO6OSuhGPKaaGssGB2qgDUS0gPgtTvoyZLTt9Ab6dC4hfc9dV5arkvc/OCmrw==", + "version": "0.6.0", + "resolved": "https://registry.npmjs.org/cookie/-/cookie-0.6.0.tgz", + "integrity": "sha512-U71cyTamuh1CRNCfpGY6to28lxvNwPG4Guz/EVjgf3Jmzv0vlDp1atT9eS5dDjMYHucpHbWns6Lwf3BKz6svdw==", "engines": { "node": ">= 0.6" } @@ -814,16 +800,16 @@ "integrity": "sha512-tvtQIeLVHjDkJYnzf2dgVMxfuSGJeM/7UCG17TT4EumTfNtF+0nebF/4zWOIkCreAbtNqhGEboB6BWrwqNaw4Q==" }, "node_modules/express": { - "version": "4.18.2", - "resolved": "https://registry.npmjs.org/express/-/express-4.18.2.tgz", - "integrity": "sha512-5/PsL6iGPdfQ/lKM1UuielYgv3BUoJfz1aUwU9vHZ+J7gyvwdQXFEBIEIaxeGf0GIcreATNyBExtalisDbuMqQ==", + "version": "4.19.2", + "resolved": "https://registry.npmjs.org/express/-/express-4.19.2.tgz", + "integrity": "sha512-5T6nhjsT+EOMzuck8JjBHARTHfMht0POzlA60WV2pMD3gyXw2LZnZ+ueGdNxG+0calOJcWKbpFcuzLZ91YWq9Q==", "dependencies": { "accepts": "~1.3.8", "array-flatten": "1.1.1", - "body-parser": "1.20.1", + "body-parser": "1.20.2", "content-disposition": "0.5.4", "content-type": "~1.0.4", - "cookie": "0.5.0", + "cookie": "0.6.0", "cookie-signature": "1.0.6", "debug": "2.6.9", "depd": "2.0.0", diff --git a/package.json b/package.json index 4a34614..1757f0a 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ "dependencies": { "@slack/bolt": "^3.8.1", "@slack/events-api": "^3.0.1", - "express": "^4.17.2", + "express": "^4.19.2", "dotenv": "^8.6.0" } }