You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It was in the decomp comment and I found it interesting so I added the issue.
There is a bug in the calculation of the number of kills for KillMaster medals. Essentially, the number of suicides must be excluded.
alone, always excludes the number of player 2 killed
2 human, always excludes the number of player 3 killed
3 human, always excludes the number of player 4 killed
4 human, always excludes the number of first simulant killed
for (j = 0; j < MAX_MPCHRS; j++) {
// @bug: i should be k. The value of i was incremented after
// the last iteration of its loop above so it'll be between
// 1 and 4 inclusively depending on the number of players.
// The bot nums start from 4 regardless of how many players
// there are. So in a game with 4 humans, the kills on the
// first bot will not be considered for the killmaster medal
// which means the medal could go to a player who got fewer
// total kills. Additionally, suicides are counted as kills
// while the intention here was to omit them.
if (i != j) {
totalkills += mpchr->killcounts[j];
}
}
The text was updated successfully, but these errors were encountered:
It was in the decomp comment and I found it interesting so I added the issue.
There is a bug in the calculation of the number of kills for KillMaster medals. Essentially, the number of suicides must be excluded.
alone, always excludes the number of player 2 killed
2 human, always excludes the number of player 3 killed
3 human, always excludes the number of player 4 killed
4 human, always excludes the number of first simulant killed
https://github.com/fgsfdsfgs/perfect_dark/blob/port/src/game/mplayer/mplayer.c#L2351-L2364
The text was updated successfully, but these errors were encountered: