Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bob: Let multiple line question example be one sentence #2498

Merged

Conversation

oleks
Copy link
Contributor

@oleks oleks commented Nov 14, 2024

Using multiple sentences is a bit ambiguous in this exercise, in general. This is especially so, if we follow a sentence with a
question mark by a sentence with a dot.

To avoid that ambiguity gettting in the way of showcasing the intended way to handle multi-line queries, let this example use just one sentence, but let it spread over multiple lines.

Disucssion: https://forum.exercism.org/t/bob-exercise-text-should-mention-linebreak-handling/13582/17

@SleeplessByte

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Nov 14, 2024
@Cool-Katt Cool-Katt reopened this Nov 14, 2024
@Cool-Katt
Copy link
Contributor

@oleks Tests are required to be immutable so to address this you'd have to implement a new test instead of changing the existing one.
More can be found in this repo's README

@oleks
Copy link
Contributor Author

oleks commented Nov 14, 2024

@oleks Tests are required to be immutable so to address this you'd have to implement a new test instead of changing the existing one. More can be found in this repo's README

Aha! Sure.

Which procedure do I use to generate a UUID for the new test case?

@oleks
Copy link
Contributor Author

oleks commented Nov 14, 2024

@oleks Tests are required to be immutable so to address this you'd have to implement a new test instead of changing the existing one. More can be found in this repo's README

Aha! Sure.

Which procedure do I use to generate a UUID for the new test case?

Never mind, now I see that that it is UUIDv4. That still leaves ambiguity as to the intended random number generator that I should use, but I will assume that Python's standard library UUIDv4 will suffice.

Using multiple sentences is a bit ambiguous in this exercise, in
general. This is especially so, if we follow a sentence with a
question mark by a sentence with a dot.

To avoid that ambiguity gettting in the way of showcasing the
intended way to handle multi-line queries, let this example use just
one sentence, but let it spread over multiple lines.

  Disucssion: https://forum.exercism.org/t/bob-exercise-text-should-mention-linebreak-handling/13582/17
@oleks oleks force-pushed the bob-use-one-sentence-in-multiline-example branch from 357a640 to da9e84e Compare November 14, 2024 08:16
@Cool-Katt
Copy link
Contributor

For future reference, configlet can generate it for you.

@Cool-Katt Cool-Katt merged commit 8ee2035 into exercism:main Nov 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants