feature(eth): add eth_blobBaseFee #3528
Conversation
There was a problem hiding this comment.
Hey @DavidRomanovizc. Thanks for the submission. I added a small note but I can also add tests here and address any issues with the tester provider. Are you OK with me picking this up and merging?
docs/web3.eth.rst
Outdated
| Fetches the expected base fee for blobs in the next block. | ||
| * Delegates to ``eth_blobBaseFee`` RPC Method | ||
|
|
||
| Returns the expected base fee in wei, represented as a hexadecimal. |
There was a problem hiding this comment.
represented as a hexadecimal.
This may be true of the JSON-RPC spec, but the library returns the formatted value as an integer. Perhaps we can leave this simpler, borrowing from the max_priority_fee_per_gas description. We also need a blank line between the first sentence and the bullet (*) in order to render the docs properly.
Fetches the expected base fee for blobs in the next block.
- Delegates to
eth_blobBaseFeeRPC MethodReturns the expected blob base fee in Wei.
This renders well
Thoughts?
There was a problem hiding this comment.
sounds reasonable. I'll fix it
OK |
What was wrong?
Related to Issue #3527
Closes #3527
How was it fixed?
eth_blobBaseFeeeth_blobBaseFeeWhile running tests, the
TestEthereumTesterEthModuleraise that the RPC method eth_blobBaseFee is unknown. It seems like updating eth-tester might resolve the issue, but I am not entirely certain.Todo:
Cute Animal Picture