Do not check macro injected code #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Premwoik
changed the title
Premwoik
force-pushed
the
do-not-check-macro-injected-code
branch
2 times, most recently
from
d251b78 to
7636815
Compare
erszcz
force-pushed
the
do-not-check-macro-injected-code
branch
from
7636815 to
6c5f0e5
Compare
erszcz
force-pushed
the
do-not-check-macro-injected-code
branch
from
fa85f68 to
163834b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #99. The spec position of the forms injected into the module by the
usemacro shouldn't be checked because it doesn't have the correct line.Ways how we can filter out injected forms:
macro_lines(locations that injected forms inherit from theusemacro) from the token stream and do not check forms with these lines.Currently, If the token stream exists, it is used to build
envthat stores info about the analysed module. Then thatenvcan be used to detect the forms injected from theusemacro. If the token stream does not exist, the second method is used.I know that only the second method should be enough, but I feel that collecting this
envinformation can be useful in other places.