Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to repos for security assignments are missing in Engineer Kit. #50

Open
kodebae opened this issue Jan 22, 2024 · 2 comments
Open

Comments

@kodebae
Copy link

kodebae commented Jan 22, 2024

Description: Some of the assignments in the "Securities" section in Engineer Kit are missing the repos to the assignments.

Expected Behavior: There should be a working link to a repo for the securities exercises that the mentee can clone down to their machine, complete , and then send to their mentors for feedback and critiquing.

Actual Behavior: Instructions for the assignment are present and added to the markdown file. However, the accompanying repo for the exercise that is mentioned in the file does not exist. The Markdown does mention a specific repo to clone, but this is not an existing repo. Even if you search for the repo on GitHub, it doesn't exist.

Relevant Information: Attached is a screenshot that highlights the exact repo for reference. This may provide more context on which assignments need to be linked. Below is the link to the specific repo that brought this to attention. This may not be the only missing assignment in EK. A thorough investigation of the assignment repos is recommended.

➡️ https://github.com/engineerkit/engineerkit/blob/main/exercises/security/broken-access-control.md

Attachments: Please see the attached screenshot.

Steps to Reproduce:

  1. (Replicate via linked repo) Navigate to the aforementioned link above. Scroll down until you see the
    "link" to the assignment repo. Try to navigate to the repo that is linked. The link is not clickable and will not redirect to an assignment.

  2. (Replicate via search) Copy and paste the repo into the search bar at the top right hand side of the page on GitHub. Hit "Enter". Note that the repo is not found.

Environment: Found via Safari: Version 17.2.1 (19617.1.17.11.12)

Screenshot 2024-01-22 at 1 53 15 PM
@chandlerroth
Copy link
Member

chandlerroth commented Jan 24, 2024

thanks for catching this, and the detailed write-up! I'll check out what's going on here :)

@kodebae
Copy link
Author

kodebae commented Jan 24, 2024

thanks for catching this, and the detailed write-up! I'll check out what's going on here :)

No problem. happy to help anytime. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants