Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc update: mention conflict with handlebars_assets #333

Open
jacquescrocker opened this issue Jan 19, 2014 · 4 comments
Open

doc update: mention conflict with handlebars_assets #333

jacquescrocker opened this issue Jan 19, 2014 · 4 comments

Comments

@jacquescrocker
Copy link
Contributor

having the handlebars_assets gem in along with ember-rails will cause an unending fury of frustration since none of the templates will ever get picked up and you wont know why

a few ideas to make this little conflict less painful to people adding ember-rails to an existing project:

low effort: add a note in the readme recommending to remove handlebars_assets when using ember-rails

medium effort: add runtime check with error message

high effort: allow both gems to work happily together

I can possibly tackle the low/medium effort items. high effort one is probably not required as long as we're clear that handlebars_assets and ember-rails are Gemfile mortal enemies

@rwjblue
Copy link
Member

rwjblue commented Jan 19, 2014

@railsjedi - I think the low + medium effort items you have listed would likely do enough to make this much less of an issue (at least on the debugging side). A PR would definitely be welcome...

@jacquescrocker
Copy link
Contributor Author

awesome, will do

@seanlinsley
Copy link
Contributor

In the debugger I noticed that the templates were being loaded up, they were just being added to the wrong object.

screen shot 2014-12-16 at 1 09 30 am

This seems to work around the issue:

window.Application = Ember.Application.create
  ready: ->
    Ember.TEMPLATES = HandlebarsTemplates

@seanlinsley
Copy link
Contributor

Turns out the that approach doesn't work because Handlebars isn't set up to use Ember's helpers. I'm not sure how to get that working, so I ended up scrapping this approach and removing the handlebars_assets gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants