Cannot resume workflow, ResumeWorkflowAsync removed

[andymartin]

Description

I just updated from 3.0.2 to 3.3.1 and the scope of undocumented breaking changes in a minor release is rather alarming.

I was previously running this code:

var activityName = ActivityTypeNameHelper.GenerateTypeName<ScientificProtocol>();
var bookmark = new ScientificProtocolBookmarkPayload(context.Message.CorrelationId);

await _runtime.ResumeWorkflowsAsync(activityName, bookmark, new TriggerWorkflowsOptions());

Now it does not compile so I have to update it. The 3.3.1 source code suggests that RunWorkflowAsync will resume suspended workflows so I changed the code to the following, I get an error stating there is no workflow instance with the ActivityInstanceId.

Any guidance on the correct way to migrate this code? Thanks!

var activityName = ActivityTypeNameHelper.GenerateTypeName<ScientificProtocol>();
var request = new RunWorkflowInstanceRequest
{
    ActivityHandle = new Elsa.Workflows.Models.ActivityHandle
    {
        ActivityId = activityName,
        ActivityInstanceId = context.Message.CorrelationId,
    },
};

var client = await _runtime.CreateClientAsync();
await client.RunInstanceAsync(request);

[goodsxx]

You can try it like this ：

1. Create bookmarks in the activity:

public record CreateTodoStimulus(long TodoId);

public class CreateTodo : CodeActivity<object>
{
public const string InputKey = "CreateTodoInput";
protected override async ValueTask ExecuteAsync(ActivityExecutionContext context)
{
  ......
    var stimulus = new CreateTodoStimulus(entity.Id);
    context.CreateBookmark(stimulus, ResumeAsync, false);
  ......
}
}

2. Resume the bookmark where you need it:

private async Task ResumeTodoBookmarkAsync(long todoId, string resultPayload, CancellationToken c = default)
{
	var stimulus = new CreateTodoStimulus(todoId);
	var input = new Dictionary<string, object>
	{
		[CreateTodo.InputKey] = resultPayload,
	};
	var activityTypeName = ActivityTypeNameHelper.GenerateTypeName<CreateTodo>();

	var bookmarkQueueItem = new NewBookmarkQueueItem
	{
		ActivityTypeName = activityTypeName,
		StimulusHash = stimulusHasher.Hash(activityTypeName, stimulus),
		Options = new ResumeBookmarkOptions
		{
			Input = input
		}
	};
	await bookmarkQueue.EnqueueAsync(bookmarkQueueItem, c);
}

[sfmskywalker]

@andymartin I should have marked obsolete members in the IWorkflowRuntime interface as such, but instead I had removed them. This will be fixed with the imminent 3.3.2 patch release.