Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the JoinRoom screen to take advantage of newer APIs and support more joinRule/membership combinations (i.e. invite required, restricted, banned) #3685

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Refactor the JoinRoom screen to take advantage of newer APIs and support more joinRule/membership combinations (i.e. invite required, restricted, banned) #3685

wants to merge 1 commit into from

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Jan 17, 2025 •
edited
Loading

  • expose the full RoomPreview and RoomMembershipDetails through their own proxies
  • implement standard mocks for all the different combinations
  • converge on a single room info provider
  • rebuild all the previews

Fixes #3677, fixes #3678

@stefanceriu
Refactor the JoinRoom screen to take advantage of newer APIs and supp…
dac7ba8 
…ort more joinRule/membership combinations (i.e. invite required, restricted, banned)

- expose the full RoomPreview and RoomMembershipDetails through their own proxies
- implement standard mocks for all the different combinations
- converge on a single room info provider
- rebuild all the previews
@stefanceriu stefanceriu added the pr-change for updates to an existing feature label Jan 17, 2025
@stefanceriu stefanceriu requested a review from a team as a code owner January 17, 2025 15:13
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team January 17, 2025 15:13
@github-actions GitHub Actions
Copy link

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against dac7ba8

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
908 1 907 0
View the full list of 1 ❄️ flaky tests 
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 16.05% (Passed 136 times, Failed 26 times)

Stack Traces | 1.75s run time 
failed - Snapshot "Ignored User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Ignored-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Ignored-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.90600586 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:85)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave Awaiting requested review from pixlwave pixlwave is a code owner automatically assigned from element-hq/element-x-ios-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pr-change for updates to an existing feature
Projects
None yet
Milestone
No milestone
1 participant
@stefanceriu