Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big (Round) Red Button?! #1105

Open
JulianKniephoff opened this issue Sep 5, 2023 · 5 comments
Open

Big (Round) Red Button?! #1105

JulianKniephoff opened this issue Sep 5, 2023 · 5 comments

Comments

@JulianKniephoff
Copy link
Member

@oas777 wrote in #1069 (comment):

  • I have a problem with the "start recording" button: It's form (ratio) differs from the general button design, the colors break the overall color scheme and it's less visible on darker content being shared. Before suggesting to aligning it and its form with the "Back" and "Stop recording" button (causing issues with dark mode probably): What do others think?

@LukasKalbertodt replied in #1069 (comment):

I think a round red button is pretty much the standard on all video recording apps, despite red not being a part of their color schemes. I also don't think it's the prettiest, but I think it's the design thats most easily understood by users.
But again: Others, what do you think?

@oas777
Copy link

oas777 commented Sep 6, 2023

No one? So it's me again: The red circle is certainly a standard - but do we need the white outline? Also, the background colour is different from the header's background (in light mode). Probably two details why this recording button feels like a "foreign matter" in terms of design.

@LukasKalbertodt
Copy link
Member

do we need the white outline?

It helps with having a strong contrast between the button and the background. My iPhone also has a white outline. We could remove it though, if we change the background and red color appropriately so that the contrast is large enough. I would probably just keep it as is?

his recording button feels like a "foreign matter" in terms of design.

Interesting. I think I understand what you mean. That said, this comes straight from Lisa's design. But yeah I suppose one could still experiment with this design a bit.

@oas777
Copy link

oas777 commented Sep 11, 2023

do we need the white outline?

It helps with having a strong contrast between the button and the background. My iPhone also has a white outline. We could remove it though, if we change the background and red color appropriately so that the contrast is large enough. I would probably just keep it as is?

The iPhone outline is pretty thick, though. This one being so thin is part of the problem.

his recording button feels like a "foreign matter" in terms of design.

Interesting. I think I understand what you mean. That said, this comes straight from Lisa's design. But yeah I suppose one could still experiment with this design a bit.

Maybe aligning the background color would do the trick for me.

@lkiesow
Copy link
Contributor

lkiesow commented Sep 14, 2023

Instead of the round button, we could also just keep our regular button style and just add an icon. This also has the nice side effect that we can actually add text describing the functionality. Something like:

@oas777
Copy link

oas777 commented Sep 14, 2023

While I like this more in principle, I would have to see this in Studio to check whether it's "visible" enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants