-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation of eiffel-intelligence-frontend periodic builds setup on Nordix Infrastructure #292
Comments
/cc @eiffel-community/eiffel-intelligence-maintainers |
As pointed out by @tobiasake this repo is dependent on https://github.com/eiffel-community/eiffel-intelligence and thus we might need some dependency handling. I have started a discussion with eiffel-community/community#74. |
@m-linner-ericsson @tobiasake I suppose we can update the logic of eiffel-intelligence-frontend job to trigger upon completion of eiffel-intelligence job in addition to triggering it based on git polling so when eiffel-intelligence changes, we rebuild eiffel-intelligence-frontend image as well. do you think this would satisfy the need? |
We are more interested that the code contributions in eiffel-intelligence are merged before we build the frontend. The two services are independent services so the build order doesn't matter but the code contributions do. Did this make it more clear what we are after? |
Let's see if I understood it correctly. ;) You are interested in commits and builds for eiffel-intelligence should be done after code is merged - which is the current setup by using polling the repo and running the build if there is any new commit since the last time repo was polled. (This can and will be switched to post merge so we build the image whenever code gets merged.) When it comes to eiffel-intelligence-frontend; the image for this one should also be built whenever a commit is merged either in eiffel-intelligence or eiffel-intelligence-frontend so builds are driven by commits rather than images. Build order of eiffel-intelligence or eiffel-intelligence-frontend images are not important since they can be built independently whenever a commit lands in the repo. Is my understanding correct? |
I guess this discussion is also done in eiffel-community/community#74 (comment). If we just build things on the latest commit and have them as dev containers without any guarantee of them working it would be fine. Because when the release builds comes we will just use them. Does this clear things up? |
Yes. The other benefit of :dev containers is that they will be useful when cutting the release since we will have already built and tested the commit to be released in advance so making a GitHub release and getting image built/tagged for that commit will hopefully be straightforward. |
Description
Periodic builds are setup for this project on Nordix Infrastructure as part of Eiffel Infrastructure and CI/CD establishment work Phase 1.
It is important the builds are reviewed by the project to ensure the build process is correct.
It would also be good if the artifact is fetched from Nordix Registry and verify it works.
Here are more details.
Build process.
mvn --quiet --batch-mode package -DskipTests
podman build --build-arg URL=target/eiffel-intelligence-frontend-3.0.1-SNAPSHOT.war --file src/main/docker/Dockerfile --log-level error --tag registry.nordix.org/eiffel/eiffel-intelligence-frontend:latest .
podman pull registry.nordix.org/eiffel/eiffel-intelligence-frontend:latest
docker pull registry.nordix.org/eiffel/eiffel-intelligence-frontend:latest
What we need from you is
podman pull registry.nordix.org/eiffel/eiffel-intelligence-frontend:latest
docker pull registry.nordix.org/eiffel/eiffel-intelligence-frontend:latest
and anything else you may think if.
Please note that upcoming phases will enable testing as well and we will reach out to you when the time comes.
Motivation
Setup builds for the project
Exemplification
N/A
Benefits
Project will have builds available
Possible Drawbacks
N/A
The text was updated successfully, but these errors were encountered: