Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecsactsi_wasm_load_file has too many mutable parameters #80

Open
zaucy opened this issue Jan 30, 2025 · 0 comments
Open

ecsactsi_wasm_load_file has too many mutable parameters #80

zaucy opened this issue Jan 30, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@zaucy
Copy link
Member

zaucy commented Jan 30, 2025

ECSACTSI_WASM_API_FN(ecsactsi_wasm_error, ecsactsi_wasm_load)
( //
	char*                  wasm_data,
	int                    wasm_data_size,
	int                    systems_count,
	ecsact_system_like_id* system_ids,
	const char**           wasm_exports
);

This is the current signature. The system_ids, wasm_data, and wasm_exports should all be immutable.

@zaucy zaucy added the bug Something isn't working label Jan 30, 2025
@zaucy zaucy changed the title ecsactsi_wasm_load_file should not need write access to system ids param ecsactsi_wasm_load_file has too many mutable parameters Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant