From 35bc9cb9f72a735bae1a20caf7f11aeff8be2ff5 Mon Sep 17 00:00:00 2001 From: Ezekiel Warren Date: Mon, 3 Jun 2024 12:27:20 -0700 Subject: [PATCH 1/2] fix: add some missing msvc debug flags --- ecsact/cli/commands/build/recipe/cook.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ecsact/cli/commands/build/recipe/cook.cc b/ecsact/cli/commands/build/recipe/cook.cc index 9f8fc4a..1224dfa 100644 --- a/ecsact/cli/commands/build/recipe/cook.cc +++ b/ecsact/cli/commands/build/recipe/cook.cc @@ -519,10 +519,16 @@ auto cl_compile(compile_options options) -> int { // compile_proc_args.push_back("/bigobj"); // } + if(options.debug) { + cl_args.push_back("/FC"); // full source paths + } + // cl_args.push_back("/we4530"); // treat exceptions as errors cl_args.push_back("/wd4530"); // ignore use of exceptions warning cl_args.push_back("/MD"); - cl_args.push_back("/DNDEBUG"); + if(!options.debug) { + cl_args.push_back("/DNDEBUG"); + } cl_args.push_back("/O2"); cl_args.push_back("/GL"); cl_args.push_back("/MP"); From 5fae56022db8d014a0b818aecfd438af8fce1097 Mon Sep 17 00:00:00 2001 From: Ezekiel Warren Date: Mon, 3 Jun 2024 12:39:16 -0700 Subject: [PATCH 2/2] fix: more flags --- ecsact/cli/commands/build/recipe/cook.cc | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/ecsact/cli/commands/build/recipe/cook.cc b/ecsact/cli/commands/build/recipe/cook.cc index 1224dfa..9dc6f61 100644 --- a/ecsact/cli/commands/build/recipe/cook.cc +++ b/ecsact/cli/commands/build/recipe/cook.cc @@ -510,24 +510,17 @@ auto cl_compile(compile_options options) -> int { cl_args.push_back("/diagnostics:column"); cl_args.push_back("/DECSACT_BUILD"); - // TODO(zaucy): Add debug mode - // if(options.debug) { - // compile_proc_args.push_back("/DEBUG:FULL"); - // compile_proc_args.push_back("/MDd"); - // compile_proc_args.push_back("/Z7"); - // compile_proc_args.push_back("/EHsc"); - // compile_proc_args.push_back("/bigobj"); - // } - - if(options.debug) { - cl_args.push_back("/FC"); // full source paths - } - // cl_args.push_back("/we4530"); // treat exceptions as errors cl_args.push_back("/wd4530"); // ignore use of exceptions warning - cl_args.push_back("/MD"); if(!options.debug) { + cl_args.push_back("/MD"); cl_args.push_back("/DNDEBUG"); + } else { + cl_args.push_back("/FC"); // full source paths + cl_args.push_back("/MDd"); + cl_args.push_back("/Z7"); + cl_args.push_back("/EHsc"); + cl_args.push_back("/bigobj"); } cl_args.push_back("/O2"); cl_args.push_back("/GL");