Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Using the TCK with an sparkplug enabled device #517

Open
1 task done
omarhogni opened this issue Mar 12, 2024 · 5 comments
Open
1 task done

Question: Using the TCK with an sparkplug enabled device #517

omarhogni opened this issue Mar 12, 2024 · 5 comments
Labels
fix added A fix has been added, but not yet in a release question Further information is requested

Comments

@omarhogni
Copy link

What do you want to know?

It seems that a device id is required for some of the tests to run properly. Is there something I am missing and this functionality already exists?

replacing the device id with a space character enables some of the tests to be run but not all of them.

Is this related to a Sparkplug Listing request? If so, link the issue from https://github.com/eclipse-sparkplug/sparkplug.listings here.

No response

Version

3.0.0 (Default)

Accept EFTL Terms

  • I agree to the terms of EFTL
@omarhogni omarhogni added the question Further information is requested label Mar 12, 2024
@bryce-nakatani
Copy link

bryce-nakatani commented Mar 12, 2024 via email

@magni-mar
Copy link

I believe he is asking weather the TCK will support Sparkplug Enabled device

image

as opposed to Edge Node

image

since Sparkplug Enabled device doesn't require device ID

@bryce-nakatani
Copy link

bryce-nakatani commented Mar 12, 2024 via email

@icraggs-sparkplug icraggs-sparkplug added this to the 3.x service release milestone Mar 14, 2024
@icraggs-sparkplug
Copy link
Contributor

I hadn't considered this variant when writing the TCK - no-one pointed it out to me either.

Does this mean that in this situation, a Sparkplug Node carries out all the operations that would otherwise be implemented by a Device?

So NDATA instead of DDATA, NCMD instead of NDATA?

That will need some TCK updates which I'll have to think about and get back to you.

@bryce-nakatani I assume we can't have a Device without a Node as well?

@bryce-nakatani
Copy link

Devices are optional to a node implementation.

I sculpted my implementation so that multiple devices could exist under the node. Thus all my implementations contain devices (even if there is only a single device possible). Tahu's Compatible Edge Node implementation also contains a device.

I have been overbiased with a node/device implementation.

I can see an implementation when a single device could be absorbed as just a node.

In the node-only case, the node publishes NDATA (similar to DDATA) and receives writes and other commands on NCMD (similar to DCMD).

@icraggs-sparkplug You're correct, devices cannot exist without a node.

icraggs-sparkplug added a commit to icraggs-sparkplug/sparkplug that referenced this issue May 19, 2024
wes-johnson added a commit that referenced this issue May 20, 2024
Allow nodes without a separate device #517
icraggs-sparkplug added a commit to icraggs-sparkplug/sparkplug that referenced this issue Jun 4, 2024
wes-johnson added a commit that referenced this issue Jun 18, 2024
Allow nodes without a separate device #517
@icraggs-sparkplug icraggs-sparkplug added the fix added A fix has been added, but not yet in a release label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix added A fix has been added, but not yet in a release question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants