Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing logout button #996

Open
emetsger opened this issue Jul 18, 2019 · 1 comment
Open

Missing logout button #996

emetsger opened this issue Jul 18, 2019 · 1 comment

Comments

@emetsger
Copy link
Contributor

emetsger commented Jul 18, 2019

There is no way for a user to logout. Perhaps add a logout button that would destroy the appropriate cookies?

Chrome, and maybe other browsers, does not destroy session cookies if you have configured the browser to "re-open all tabs" when you re-start. So closing the tab or quitting the browser in that scenario doesn't actually log you out - the session cookies remain.

Affects pass-docker f2361f2 and pass-ember 790edea

@jabrah
Copy link
Contributor

jabrah commented Jul 22, 2019

If you click on your name/username in the top right, it should bring up a context menu with a Logout option. This is at least the case in TEST.

Does this not appear? If it does, should Logout be made more obvious and be shown outside of this?

If you're curious, logging out requires a customization in the backend. Since the browser is not the entity that set the login cookies when the user was authenticated - this was done by Shib - PASS is blocked by the browser from modifying the cookie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants