Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Telephony API Wrapper to Fix Parameter Handling #286

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

TreWilkins
Copy link

Description

Refactored the Telephony API wrapper to properly handle user-provided parameters, ensuring that mintime and other arguments are correctly passed in V2 requests. Updated get_telephony_log to avoid incorrect kwargs nesting and allow proper extraction of parameters.

Motivation and Context

This change is required because user-provided arguments, including mintime, were not being sent in Telephony V2 requests due to incorrect kwargs handling. This fixes the issue by ensuring that parameters are correctly extracted and included in the request.

Fixes: #285

How Has This Been Tested?

  • Added tests to validate that mintime and other parameters are correctly passed in V2 requests.
  • Verified the request parameters manually to confirm correct behavior.
  • Ran existing test suites to ensure no regressions in functionality.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User-Provided Arguments Not Being Sent in Telephony V2 Requests
1 participant