-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Inno Setup 6.3.0+ #174
Conversation
@dscharrer can you review this? |
@crackedmind Hi, bud. Could you please compile your version and upload it somewhere? |
Please support Inno Setup 6.3.0! Thanks! |
So is there any reason in particular I shouldn't merge https://github.com/dscharrer/innoextract/pull/174.patch and try to compile it myself? |
@crackedmind thanks for taking the time to patch in support. I built from crackedmind/innoextract@ef31ac4 and it works for the files I needed (although I did have to add a missing include for Is there a reason this PR was closed @dscharrer? It would be nice to have these changes mainlined since the same ci pipelines failing here are also failing on master AFAICT. |
i closed PR myself. because @dscharrer won't merge it. you can try my fork, or some forks based on mine, |
Any idea why that is? |
Do you mean that @dscharrer had explicitly said that he won't merge it or that he hasn't been around to merge it? E.g., I see that a repo owner deleted one of your comments @crackedmind; was that related? |
Fix #173