Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Inno Setup 6.3.0+ #174

Closed
wants to merge 2 commits into from

Conversation

crackedmind
Copy link

Fix #173

@crackedmind
Copy link
Author

@dscharrer can you review this?

@JustDj-Git
Copy link

@crackedmind Hi, bud. Could you please compile your version and upload it somewhere?

Repository owner deleted a comment from crackedmind Jul 10, 2024
@crackedmind crackedmind deleted the feat/inno_6.3 branch July 11, 2024 16:12
@leochou0729
Copy link

Please support Inno Setup 6.3.0! Thanks!

@God-damnit-all
Copy link

So is there any reason in particular I shouldn't merge https://github.com/dscharrer/innoextract/pull/174.patch and try to compile it myself?

@kalebo
Copy link

kalebo commented Nov 21, 2024

@crackedmind thanks for taking the time to patch in support. I built from crackedmind/innoextract@ef31ac4 and it works for the files I needed (although I did have to add a missing include for unordered_map).

Is there a reason this PR was closed @dscharrer? It would be nice to have these changes mainlined since the same ci pipelines failing here are also failing on master AFAICT.

@crackedmind
Copy link
Author

crackedmind commented Nov 29, 2024

@crackedmind thanks for taking the time to patch in support. I built from crackedmind/innoextract@ef31ac4 and it works for the files I needed (although I did have to add a missing include for unordered_map).

Is there a reason this PR was closed @dscharrer? It would be nice to have these changes mainlined since the same ci pipelines failing here are also failing on master AFAICT.

i closed PR myself. because @dscharrer won't merge it. you can try my fork, or some forks based on mine,
https://github.com/czoins/innoextract/ added .iss extractation

@God-damnit-all
Copy link

God-damnit-all commented Nov 29, 2024

because @dscharrer won't merge it

Any idea why that is?

@kalebo
Copy link

kalebo commented Dec 4, 2024

Do you mean that @dscharrer had explicitly said that he won't merge it or that he hasn't been around to merge it? E.g., I see that a repo owner deleted one of your comments @crackedmind; was that related?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New InnoSetup version just released
5 participants