Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 12680 [HDPI]The dot line disappeared between checkbox and Expand/collapse in HDPI mode #12706

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Epica3055
Copy link
Member

@Epica3055 Epica3055 commented Jan 3, 2025

Fixes #12680

Root Cause

The default indent is 19, but we didn't scale it properly in HDPI mode.

Proposed changes

  • scale indent properly in HDPI mode.

Screenshots

Before

Image

After

image

Test methodology

  • manually
Microsoft Reviewers: Open in CodeFlow

@Epica3055 Epica3055 requested a review from a team as a code owner January 3, 2025 09:43
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.04123%. Comparing base (58d5c74) to head (ea0cb11).
Report is 34 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12706         +/-   ##
===================================================
+ Coverage   76.03484%   76.04123%   +0.00638%     
===================================================
  Files           3180        3181          +1     
  Lines         639637      639674         +37     
  Branches       47213       47216          +3     
===================================================
+ Hits          486347      486416         +69     
+ Misses        149773      149740         -33     
- Partials        3517        3518          +1     
Flag Coverage Δ
Debug 76.04123% <0.00000%> (+0.00638%) ⬆️
integration 18.19469% <0.00000%> (+0.02950%) ⬆️
production 49.84061% <0.00000%> (+0.01442%) ⬆️
test 97.03140% <ø> (+0.00016%) ⬆️
unit 47.04470% <0.00000%> (-0.00369%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

@Tanya-Solyanik Tanya-Solyanik added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jan 6, 2025
@Epica3055 Epica3055 merged commit 5a19e21 into dotnet:main Jan 7, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 7, 2025
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jan 7, 2025
ricardobossan pushed a commit to ricardobossan/winforms that referenced this pull request Jan 9, 2025
…xpand/collapse in HDPI mode (dotnet#12706)

fix issue 12680  [HDPI]The dot line disappeared between checkbox and Expand/collapse in HDPI mode
Epica3055 added a commit to Epica3055/winforms that referenced this pull request Jan 16, 2025
…ox and Expand/collapse in HDPI mode (dotnet#12706)"

This reverts commit 5a19e21.
Epica3055 added a commit that referenced this pull request Jan 17, 2025
#12798)

Revert "fix issue 12680 [HDPI]The dot line disappeared between checkbox and Expand/collapse in HDPI mode (#12706)"
Epica3055 added a commit to Epica3055/winforms that referenced this pull request Jan 23, 2025
…ox and Expand/collapse in HDPI mode (dotnet#12706)"

This reverts commit 5a19e21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HDPI]The dotted line between the checkbox and expand/collapse of the TreeView control disappears in HDPI mode
2 participants