Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpHandlerDiagnosticListener might emit HttpRequestOut.Start 2 times for certain hosts with ActivityIdFormat.W3C #112792

Open
antonfirsov opened this issue Feb 21, 2025 · 3 comments

Comments

@antonfirsov
Copy link
Member

antonfirsov commented Feb 21, 2025

#112426 captures 2 test failures: TestW3CHeadersTraceStateAndCorrelationContext is a test bug to be fixed by #112753. However the test TestW3CHeaders also fails on this assertion, which seems to be a product bug.

The reason behind the failure is that when

  1. HttpClient is used (vs HttpWebRequest)
  2. With ActivityIdFormat.W3C (vs the default Hierarchical format)
  3. To certain endpoints (eg. to http://corefx-net-http11.azurewebsites.net/Echo.ashx but not http://example.com)

the event System.Net.Http.Desktop.HttpRequestOut.Start is emitted 2 times for the same HttpWebRequest. There are no multiple physical requests being sent. All 3 conditions have to be met.

A minimal repro can be found here.

My guess is this bug has been around for a long time, and no user reported it, so I would assess the priority as low, but I'm letting the owners to triage.

Related: #38152

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Feb 21, 2025
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@tommcdon
Copy link
Member

@karelz @tarekgh @noahfalk

@tarekgh
Copy link
Member

tarekgh commented Feb 21, 2025

@antonfirsov is tracking to look at this as I understand. @antonfirsov please let me know if this is not the case. Thanks!

@tarekgh tarekgh added this to the Future milestone Feb 21, 2025
@tarekgh tarekgh removed the untriaged New issue has not been triaged by the area owner label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants