From e42f3d8bf114571f2c2e299bd95ab3513cd39348 Mon Sep 17 00:00:00 2001
From: Joey Robichaud <jorobich@microsoft.com>
Date: Wed, 1 May 2024 15:55:00 -0700
Subject: [PATCH] PR feedback.

---
 eng/Publishing.props                   | 13 +++++++------
 eng/SymbolPublishingExclusionsFile.txt |  5 -----
 eng/build.ps1                          |  3 ---
 3 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/eng/Publishing.props b/eng/Publishing.props
index c5c83efca092a..0f367adff3e22 100644
--- a/eng/Publishing.props
+++ b/eng/Publishing.props
@@ -8,14 +8,15 @@
     <PublishDependsOnTargets>_ResolvePublishRoslynNuGetPackages;$(PublishDependsOnTargets)</PublishDependsOnTargets>
   </PropertyGroup>
 
+  <!--
+    During PR Validation we only need to publish symbols with Arcade,
+    since our packages are published separately to the CoreXT feed.
+  -->
   <Target Name="_ResolvePublishRoslynNuGetPackages"
           DependsOnTargets="BeforePublish"
-          BeforeTargets="PublishToAzureDevOpsArtifacts">
-    <!--
-      During PR Validation we only need to publish symbols with Arcade,
-      since our packages are published separately to the CoreXT feed.
-    -->
-    <ItemGroup Condition=" '$(PreReleaseVersionLabel)' == 'pr-validation' ">
+          BeforeTargets="PublishToAzureDevOpsArtifacts"
+          Condition=" '$(PreReleaseVersionLabel)' == 'pr-validation' ">
+    <ItemGroup>
       <!-- Determine all NuGet packages being published -->
       <_NuGetPackagesToPush Include="@(ItemsToPushToBlobFeed)"
                             Condition=" '%(Extension)' == '.nupkg' " />
diff --git a/eng/SymbolPublishingExclusionsFile.txt b/eng/SymbolPublishingExclusionsFile.txt
index 7f69b5489513b..1a5fa3389baa2 100644
--- a/eng/SymbolPublishingExclusionsFile.txt
+++ b/eng/SymbolPublishingExclusionsFile.txt
@@ -1,10 +1,5 @@
-content/LanguageServer/alpine-arm64/libe_sqlite3.so
-content/LanguageServer/alpine-x64/libe_sqlite3.so
 content/LanguageServer/linux-musl-arm64/libe_sqlite3.so
 content/LanguageServer/linux-musl-x64/libe_sqlite3.so
-content/LanguageServer/neutral/runtimes/alpine-arm64/native/libe_sqlite3.so
-content/LanguageServer/neutral/runtimes/alpine-arm/native/libe_sqlite3.so
-content/LanguageServer/neutral/runtimes/alpine-x64/native/libe_sqlite3.so
 content/LanguageServer/neutral/runtimes/linux-musl-arm64/native/libe_sqlite3.so
 content/LanguageServer/neutral/runtimes/linux-musl-arm/native/libe_sqlite3.so
 content/LanguageServer/neutral/runtimes/linux-musl-x64/native/libe_sqlite3.so
\ No newline at end of file
diff --git a/eng/build.ps1 b/eng/build.ps1
index af07424b5c0d2..edbcc77f9ec0e 100644
--- a/eng/build.ps1
+++ b/eng/build.ps1
@@ -260,8 +260,6 @@ function BuildSolution() {
 
   $restoreUseStaticGraphEvaluation = $true
 
-  $symbolPublishingExcludeFile = Join-Path $RepoRoot "eng\SymbolPublishingExclusionsFile.txt"
-
   try {
     MSBuild $toolsetBuildProj `
       $bl `
@@ -284,7 +282,6 @@ function BuildSolution() {
       /p:RestoreUseStaticGraphEvaluation=$restoreUseStaticGraphEvaluation `
       /p:VisualStudioIbcDrop=$ibcDropName `
       /p:VisualStudioDropAccessToken=$officialVisualStudioDropAccessToken `
-      /p:SymbolPublishingExclusionsFile=$symbolPublishingExcludeFile `
       $suppressExtensionDeployment `
       $msbuildWarnAsError `
       $buildFromSource `