-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gradle version for AndroidNative app from 7.6.1 to 8.10.2. #27859
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- src/Core/AndroidNative/build.gradle: Language not supported
- src/Core/AndroidNative/gradle/wrapper/gradle-wrapper.properties: Language not supported
Hey there @LoopedBard3! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failing to build
/Users/builder/azdo/_work/3/s/.dotnet/packs/Microsoft.Android.Sdk.Darwin/35.0.39/tools/Microsoft.Android.Sdk.Bindings.Gradle.targets(83,5): error XAGRDL0000: > Namespace not specified. Specify a namespace in the module's build file: /Users/builder/azdo/_work/3/s/src/Core/AndroidNative/maui/build.gradle. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace. [/Users/builder/azdo/_work/3/s/src/Core/src/Core.csproj::TargetFramework=net9.0-android35.0]
/Users/builder/azdo/_work/3/s/.dotnet/packs/Microsoft.Android.Sdk.Darwin/35.0.39/tools/Microsoft.Android.Sdk.Bindings.Gradle.targets(83,5): error XAGRDL0000: [/Users/builder/azdo/_work/3/s/src/Core/src/Core.csproj::TargetFramework=net9.0-android35.0]
It selected `gradle-8.10.2` but then also updated other files. Let's give this a try.
I just opened this in Android Studio and let it do the "gradle upgrade". It did different things, but let's see what happens. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
> A problem occurred configuring project ':maui'. > Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl. > Namespace not specified. Specify a namespace in the module's build file: /Users/builder/azdo/_work/3/s/src/Core/AndroidNative/maui/build.gradle. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
package="com.microsoft.maui" found in source AndroidManifest.xml Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported, and the value is ignored. Recommendation: remove package="com.microsoft.maui" from the source AndroidManifest.xml:
TintTypedArray styledAttributes = TintTypedArray.obtainStyledAttributes(context, null, R.styleable.Toolbar, resId, 0);
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description of Change
Updates the gradle version for the AndroidNative app from 7.6.1 to 8.12.1. Once backported to net9.0 this will fix a performance pipeline issue that is being hit due to the gradle version being too old, specifically:
BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 65
when gradle is running during the build of the app atsrc/Core/tests/Benchmarks.Droid/Benchmarks.Droid.csproj
.This also needs to be backported to the net9.0 branch.