Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for CA2024 #44401

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Add documentation for CA2024 #44401

merged 3 commits into from
Jan 16, 2025

Conversation

mpidash
Copy link
Contributor

@mpidash mpidash commented Jan 16, 2025 •
edited by github-actions bot
Loading

@mpidash mpidash requested review from gewarren and a team as code owners January 16, 2025 02:29
@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 16, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Jan 16, 2025
gewarren
gewarren approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one small suggestion. Thanks so much @mpidash!

docs/fundamentals/code-analysis/quality-rules/ca2024.md Outdated Show resolved Hide resolved
@mpidash @gewarren
Apply suggestion from code review
1ca7329 
Co-authored-by: Genevieve Warren <[email protected]>
@mpidash
Copy link
Contributor Author

mpidash commented Jan 16, 2025

Thanks for the review, I've applied your suggestion!

@gewarren gewarren enabled auto-merge (squash) January 16, 2025 19:44
@gewarren gewarren merged commit cf92601 into dotnet:main Jan 16, 2025
8 checks passed
@mpidash mpidash deleted the ca2024 branch January 16, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@mpidash @gewarren