Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureTools][Aspire][Question] Should the "Hide Timestamp" setting also apply to "Console Logs" in Resources? #7137

Closed
amnabatr1sha opened this issue Jan 17, 2025 · 2 comments · Fixed by #7220
Assignees
Milestone

Comments

@amnabatr1sha
Copy link

Clean machine: Win11 x64 24H2 ENU
VS Version: VS 17.13.0 Preview 3.0 [35716.79.d17.13]
Aspire Version: 9.1.0-preview.1.25066.1
Apply NuGet Feeds
Podman Desktop: 1.15.0
Podman CLI: 5.3.1

Repro Steps:
1.Create a new Aspire starter project -> F5 the project.
2. In the Dashboard, click on Console in the sidebar -> Click "Settings" on the Console and select "Hide Timestamps" option.
3. Navigate to Resources and click on Console Logs.
4. Check whether the timestamps in the Console Logs are shown.

Actual:
Timestamps are still shown in Console Logs despite choosing "Hide Timestamps" in Console.

Image

Question:
Should the "Hide Timestamp" setting also apply to "Console Logs" in Resources?

More Info:
This issue doesn't reproduce if I click on Console log directly or switch to different resources in the "Console Logs".

@davidfowl davidfowl added area-dashboard untriaged New issue has not been triaged labels Jan 17, 2025
@davidfowl
Copy link
Member

cc @JamesNK

@JamesNK JamesNK added this to the Backlog milestone Jan 18, 2025
@JamesNK
Copy link
Member

JamesNK commented Jan 18, 2025

Timestamp setting is saved in the querystring. If there is no querystring, e.g. the path is just /consolelogs/, then the last settings are restored (including the timestamp). This happens when you click on console logs in the menu. But if there is a resource specified - which the resource page does when it shows logs for a resource - then there is extra content and the timestamp is always shown.

I think the fix here is storing the timestamp setting independent of other console logs page state. It should be saved and restored with unprotected browser storage. Splitting this setting off from what was last viewed is a good improvement. We would fix this bug and it would be preseved between starting/stopping the dashboard.

@JamesNK JamesNK removed this from the Backlog milestone Jan 18, 2025
@davidfowl davidfowl added untriaged New issue has not been triaged and removed untriaged New issue has not been triaged labels Jan 18, 2025
@adamint adamint self-assigned this Jan 21, 2025
@adamint adamint removed the untriaged New issue has not been triaged label Jan 21, 2025
@joperezr joperezr added the untriaged New issue has not been triaged label Jan 21, 2025
@adamint adamint removed the untriaged New issue has not been triaged label Jan 21, 2025
@adamint adamint added this to the 9.1 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants