-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flags option for dokku_service_link #80
Conversation
6b0be7d
to
50b09f6
Compare
hi @nerg4l , thanks for this addition.
I don't know either; perhaps try it out?
if you're asking about how to add tests, then you can simply add tasks to https://github.com/dokku/ansible-dokku/blob/master/molecule/default/verify.yml I guess for some of these flags you will be able to check whether they have taken effect? |
Thanks. I will try out the command on a droplet today. About the testing part, I just want to know how can I try this in development Ansible role. |
When an app is already linked then running the link command again regarding of flags will result in the following message:
However, I couldn't find a way to tell if a flag is active or not. As you said, I can only test if the flag has taken effect. |
@josegonzalez is there a way to check for this information without running the link command? @nerg4l if there doesn't turn out to be a way to check, and if the the exit code when re-running the link command is 0 ( |
For checking an existing link one can use |
hi @nerg4l , in case you want to look back into this at some point: As you point out, for a "proper" implementation, the module would need a way to determine the current state of the flags and, if it differs from the requested one, unlink and link again. If that is difficult, and if being able to set the flags via the role is very useful, I would also be ok with ignoring a change in requested flags for a link that has already been created, as long as this shortcoming is clearly documented in the description of the |
There isnt a good way to check with url we link with atm, but maybe we can have a that be part of the |
What other things are missing, either from report or other output? |
@josegonzalez It should be enough if |
I'm closing this stale PR since it has been waiting more than 12 months for input. The last stage was looking for a change in dokku for I'm happy to also accept a workaround without this functionality if desired. Feel free to reopen this PR when resuming work on it. |
This PR contains changes to support
--link-flags
when usingdokku_service_link
. This might be a bit naive approach as I'm not sure if you can change these flags by calling the command again or you have tounlink
first and then calllink
again.Also, I am not sure how to test the functionality properly. I would appreciate some help with that.
Closes #68