Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: --alias support for dokku_service_link #68

Open
jbothma opened this issue May 12, 2020 · 1 comment
Open

Request: --alias support for dokku_service_link #68

jbothma opened this issue May 12, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@jbothma
Copy link

jbothma commented May 12, 2020

Description of problem

The service support is awesome, thanks!

The --alias argument to link is awesome to that apps don't need to have dokku-specific environment variable names.

It would be great to be able to specify the alias to the dokku_service_link task
e.g.

- name: App is linked to rabbitmq instance
  dokku_service_link:
    app: "{{ app_name }}"
    name: "{{ app_name }}"
    service: rabbitmq
    alias: CELERY_BROKER_URL

would effectively be

dokku redis:link writeinpublic writeinpublic --alias CELERY_BROKER_URL
@josegonzalez josegonzalez added the enhancement New feature or request label May 12, 2020
@nerg4l
Copy link
Contributor

nerg4l commented Sep 27, 2020

Can I suggest a more generic approach for link-flags? Something like the following:

- name: App is linked to rabbitmq instance
  dokku_service_link:
    app: "{{ app_name }}"
    name: "{{ app_name }}"
    service: rabbitmq
    flags:
      alias: CELERY_BROKER_URL
      querystring "pool=5"

Which would be executed as:

dokku redis:link writeinpublic writeinpublic --alias "CELERY_BROKER_URL" --querystring "pool=5"

This would allow any custom flag for third party plugins and might make the feature a bit more future proof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants