Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dokku_vhost_enable 'false' not disabling VHOSTS on install #20

Open
austinbachman opened this issue Aug 21, 2019 · 3 comments
Open

dokku_vhost_enable 'false' not disabling VHOSTS on install #20

austinbachman opened this issue Aug 21, 2019 · 3 comments

Comments

@austinbachman
Copy link

Relevant parts from my playbook:

  roles:
    - dokku_bot.ansible_dokku
  vars:
    dokku_vhost_enable: 'false'
    dokku_plugins:
      - name: redis
        url: https://github.com/dokku/dokku-redis.git

VHOSTS are not being disabled on dokku install. Creating an app and checking the domains yields:

=====> ruby-getting-started domains information
       Domains app enabled:           true
       Domains app vhosts:            ruby-getting-started.server-name
       Domains global enabled:        true
       Domains global vhosts:         server-name

However, checking the debconf on the target node gives the following, which makes me think this may actually be an issue with dokku? I've never had this issue when doing an unattended installation without Ansible though, so I'm unsure.

* dokku/web_config: false
* dokku/key_file: /root/.ssh/id_rsa.pub
* dokku/skip_key_file: false
* dokku/vhost_enable: false
  dokku/nginx_enable: true
* dokku/hostname: dokku.me
@josegonzalez
Copy link
Member

Is this a fresh install, or an existing install?

@austinbachman
Copy link
Author

Is this a fresh install, or an existing install?

This is a fresh install on a brand new VM

@ltalirz
Copy link
Member

ltalirz commented Jan 9, 2020

I can confirm this - but only when re-creating apps that existed before.

I.e. when I

  • create an app
  • then change the vhost_enable setting
  • destroy the app
  • create the app again

then, the vhost_enable setting of the app remains the original one from when it was originally created.

However, when I

  • change the vhost_enable setting
  • create a new app (of a name that was never created before)

then, the vhost_enable setting of the app follows the system setting.

I also noticed that when I delete the /home/dokku/VHOST file manually, and then change the hostname via ansible, the VHOST file is not recreated (while the deb conf is correctly updated).

It seems to me that updating the deb conf (which is the only thing that changes when re-running the ansible role with modified variables) is not enough to actually make all of dokku aware of the updated settings. Perhaps some further reloading mechanisms would need to be added as handlers?

Perhaps @josegonzalez can provide some pointers on how to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants