Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social blog icons missing #445

Open
raffaellasuardini opened this issue Jan 13, 2025 · 9 comments
Open

Social blog icons missing #445

raffaellasuardini opened this issue Jan 13, 2025 · 9 comments

Comments

@raffaellasuardini
Copy link
Contributor

Social icons are missing from the blog home page and detail blog page.

@raffaellasuardini
Copy link
Contributor Author

@tim-schilling could be related to Puput?

@tim-schilling
Copy link
Member

Were they there before?

@raffaellasuardini
Copy link
Contributor Author

Yes, I remember they were there before this PR #437 was submitted.

@tim-schilling
Copy link
Member

Screenshot from 2025-01-14 08-50-46
Did they move? I see them here.

@tim-schilling
Copy link
Member

Oh, you mean on the share area.

@tim-schilling
Copy link
Member

tim-schilling commented Jan 14, 2025

#437 upgrading the font-awesome broke puput's version expectations for font-awesome.

@raffaellasuardini
Copy link
Contributor Author

Yes, the footer used the 6.7 because I upgraded last time

@tim-schilling
Copy link
Member

I think we need to change these:

{% post_to_facebook post_url '<span><i class="fa fa-facebook"></i></span>' %}

And then do a search for any other fa classes and see if they need updates.

@raffaellasuardini
Copy link
Contributor Author

I had to upgrade because the bluesky icon was not available on version 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants