Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dart sass division "/" syntax error, use calc() instead #1183

Open
9ete opened this issue May 4, 2022 · 0 comments
Open

Fix dart sass division "/" syntax error, use calc() instead #1183

9ete opened this issue May 4, 2022 · 0 comments

Comments

@9ete
Copy link

9ete commented May 4, 2022

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/magnific-popup/src/css/_settings.scss b/node_modules/magnific-popup/src/css/_settings.scss
index 75eadbc..88a930b 100644
--- a/node_modules/magnific-popup/src/css/_settings.scss
+++ b/node_modules/magnific-popup/src/css/_settings.scss
@@ -27,7 +27,7 @@ $mfp-include-iframe-type:             true !default;                       // En
 $mfp-iframe-padding-top:              40px !default;                       // Iframe padding top
 $mfp-iframe-background:               #000 !default;                       // Background color of iframes
 $mfp-iframe-max-width:                900px !default;                      // Maximum width of iframes
-$mfp-iframe-ratio:                    9/16 !default;                       // Ratio of iframe (9/16 = widescreen, 3/4 = standard, etc.)
+$mfp-iframe-ratio:                    calc( 9 / 16 ) !default;                       // Ratio of iframe (9/16 = widescreen, 3/4 = standard, etc.)
 
 // Image-type options
 $mfp-include-image-type:              true !default;                       // Enable Image-type popups

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant