Tests failing on macOS

[pjknowles]

Failures such as the following come after building with no options given to configure on macOS catalina.

test/1t/scale.cxx:91: FAILED:
{Unknown expression after the reported line}
with expansion:

due to a fatal error condition:
Template parameter: dcomplex
Trial 15 of 50
irrep_A = 1
dense irrep_A = 0
dense len_A =
[[2, 0], [0, 1]]
idx irrep_A = [0, 1]
idx len_A = [1, 2]
nidx_A = 1
data_A =
[0x0]
indices_A =
[[0, 0]]
idx_A = ab cd
SIGABRT - Abort (abnormal termination) signal

test3.log
test2.log
test1.log
config.log

config.status.suffix.that.github.allows.txt

[pjknowles]

Not just macOS ... here on our compute cluster.
test1.log
config.log

[devinamatthews]

@pjknowles can you attach the config.log from src/external/tci?

[devinamatthews]

@pjknowles on MacOS it looks like this was a race condition in the pthreads code. I pushed a fix to the develop branch. I'm testing all the threading backends now before I push to master.

FYI using OpenMP will almost certainly be faster since the pthreads version doesn't use a thread pool. On MacOS (in develop for now) you can use OpenMP with Apple's version of clang as long as you have libomp installed (e.g. via homebrew).

[pjknowles]

@pjknowles can you attach the config.log from src/external/tci?

config.log

[pjknowles]

@pjknowles on MacOS it looks like this was a race condition in the pthreads code. I pushed a fix to the develop branch. I'm testing all the threading backends now before I push to master.

FYI using OpenMP will almost certainly be faster since the pthreads version doesn't use a thread pool. On MacOS (in develop for now) you can use OpenMP with Apple's version of clang as long as you have libomp installed (e.g. via homebrew).

libomp 9.0.0 is already installed