Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quoted email address is parsed too greedy and is wrong by that #78

Open
r10s opened this issue Jun 15, 2024 · 3 comments
Open

quoted email address is parsed too greedy and is wrong by that #78

r10s opened this issue Jun 15, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@r10s
Copy link
Member

r10s commented Jun 15, 2024

in 1.46.4 (maybe also before), an email address written into quotes becomes tappable including the quotes.

tapping, the email address including the quotes is set as address to the core. the quotes in the alert are part of the address, not to surround the placeholder:

Screenshot 2024-06-15 at 12 00 24

even if " can be a valid characters of the local part (never seen such an address), the top-level-domain de" is definitely invalid.

interestingly, messages can still be sent, despite of the wrong address - either core or some relays are graceful here - maybe accidentally and also buggy? -, but we should not depend on that.

filing the issue here as it is unclear if it is message-parser or sth. else and how to fix. android/ios do not have the issue.

@r10s r10s added the bug Something isn't working label Jun 15, 2024
@r10s r10s changed the title quoted email address is parsed to greedy and is wrong by that quoted email address is parsed too greedy and is wrong by that Jun 15, 2024
@Simon-Laux
Copy link
Member

filing the issue here as it is unclear if it is message-parser or sth. else and how to fix. android/ios do not have the issue.

can only be message-parser

@Simon-Laux Simon-Laux transferred this issue from deltachat/deltachat-desktop Jun 15, 2024
@Simon-Laux
Copy link
Member

I have a new case: also happens on "@Name"

@Simon-Laux
Copy link
Member

Simon-Laux commented Jul 21, 2024

another case is trailing dots like reach me at [email protected].... or not... your choice..., there the email parsing is too greedy and returns: [email protected]... (last dot is correctly ignored but the extra dots before that not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants