Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve usability for SSM:Parameters - remove public property ResourceType #1076

Open
markussiebert opened this issue Nov 22, 2024 · 0 comments · May be fixed by #1089
Open

Improve usability for SSM:Parameters - remove public property ResourceType #1076

markussiebert opened this issue Nov 22, 2024 · 0 comments · May be fixed by #1089

Comments

@markussiebert
Copy link
Contributor

we expose the property resourceType to our users. This is bad and not required, as we already have Constructs for each resource type.

We should remove this from the public props, and set it in each Construct to the required value.

cdk-sops-secrets/src/SopsSync.ts

Line 144 in 23ac30a

readonly resourceType?: ResourceType;

markussiebert added a commit that referenced this issue Jan 13, 2025
@markussiebert
feat: refactor / additional flag autoGenerateIamPermissions
b466435 
- remove CreationType (Single, Multi)
- replace with ResourceType (PARAMETER_MULTI) and move it to properties
   fixes: #1076
- add property 'autoGenerateIamPermissions'
   fixes: #1087
- add property 'role' for SopsSyncProvider
   fixes: #1087
- move resourceType from syncOptions to syncProperties, as it shouldn't be set by users
- move permissionhandling to own functions, to reduce cyclomatic compexity
@markussiebert markussiebert linked a pull request Jan 13, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: refactor / additional flag autoGenerateIamPermissions dbsystel/cdk-sops-secrets
1 participant
@markussiebert